Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preflight check to guard against wrong versions of webpack/eslint/jest higher up the tree #3771

Merged
merged 6 commits into from
Jan 13, 2018
Merged

Add preflight check to guard against wrong versions of webpack/eslint/jest higher up the tree #3771

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0f01012
Run real scripts in local development
gaearon Jan 13, 2018
236653b
Add preflight check warning
gaearon Jan 13, 2018
0189867
I know what I am doing
gaearon Jan 13, 2018
34ee0de
Move preflight check into individual scripts
gaearon Jan 13, 2018
e70e64e
Slightly tweak the wording
gaearon Jan 13, 2018
851feb7
Fix lint
gaearon Jan 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Slightly tweak the wording
  • Loading branch information
@gaearon
gaearon committed Jan 13, 2018
commit e70e64ef69f11a45ab10f7b8f8f166f6ac1a61b1
14 changes: 8 additions & 6 deletions packages/react-scripts/scripts/utils/verifyPackageTree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function verifyPackageTree() {
if (depPackageJson.version !== expectedVersion) {
console.error(
chalk.red(
`There might be a problem with the project dependency tree.\n` +
`\nThere might be a problem with the project dependency tree.\n` +
`It is likely ${chalk.bold(
'not'
)} a bug in Create React App, but something you need to fix locally.\n\n`
Expand All @@ -83,14 +83,15 @@ function verifyPackageTree() {
chalk.green(
` "${chalk.bold(dep)}": "${chalk.bold(expectedVersion)}"\n\n`
) +
`Don't try to install it manually: your package manager does it automatically.\n` +
`However, a different version of ${chalk.bold(
dep
)} was detected higher up in the tree:\n\n` +
` ${chalk.bold(chalk.red(maybeDep))} (version: ${chalk.bold(
chalk.red(depPackageJson.version)
)}) \n\n` +
`This is known to cause hard-to-debug issues.\n` +
`Try following these steps:\n\n` +
`Manually installing incompatible versions is known to cause hard-to-debug issues.\n` +
`To fix the dependency tree, try following the steps below in the exact order:\n\n` +
` ${chalk.cyan('1.')} Delete ${chalk.bold(
'package-lock.json'
)} (${chalk.underline('not')} ${chalk.bold(
Expand All @@ -113,7 +114,8 @@ function verifyPackageTree() {
)} or ${chalk.bold(
'yarn'
)}, depending on the package manager you use.\n\n` +
`If this has not helped, there are a few other things to try:\n\n` +
`In most cases, this should be enough to fix the problem.\n` +
`If this has not helped, there are a few other things you can try:\n\n` +
` ${chalk.cyan('5.')} If you used ${chalk.bold(
'npm'
)}, install ${chalk.bold(
Expand All @@ -123,7 +125,7 @@ function verifyPackageTree() {
` ${chalk.cyan('6.')} Check if ${chalk.bold(
maybeDep
)} is outside your project directory.\n` +
` For example, you might have installed something accidentally in your home folder.\n\n` +
` For example, you might have accidentally installed something in your home folder.\n\n` +
` ${chalk.cyan('7.')} Try running ${chalk.bold(
`npm ls ${dep}`
)} in your project folder.\n` +
Expand All @@ -135,7 +137,7 @@ function verifyPackageTree() {
`If nothing else helps, add ${chalk.bold(
'SKIP_PREFLIGHT_CHECK=true'
)} to an ${chalk.bold('.env')} file in your project.\n` +
`This permanently disables this preflight check in case you want to proceed anyway.\n\n` +
`That would permanently disable this preflight check in case you want to proceed anyway.\n\n` +
chalk.cyan(
`P.S. We know this message is long but please read the steps above :-) We hope you find them helpful!\n`
)
Expand Down