Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a reasonable config for autoprefixer (resolves #73) #345

Merged
merged 2 commits into from
Aug 4, 2016

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Aug 3, 2016

No description provided.

@ghost
Copy link

ghost commented Aug 3, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the CLA Signed label Aug 3, 2016
@ghost
Copy link

ghost commented Aug 3, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mxstbr
Copy link
Contributor

mxstbr commented Aug 3, 2016

Why would we put that in a global file and not config/webpack.config.*.js?

@gaearon
Copy link
Contributor

gaearon commented Aug 3, 2016

Yeah, this should be a part of Webpack configs.

@alexzherdev
Copy link
Contributor

The original issue #73 mentions an issue with css-loader which could be fixed via a browser list file, but it also mentions an alternative fix, so maybe that one could be used here. (supplying an option to css-loader)

@kripod
Copy link
Contributor Author

kripod commented Aug 3, 2016

@mxstbr @gaearon I thought following the DRY principle was a better way to go instead of filling the same values in twice. I could change it tomorrow if you want, though.

@ghost ghost added the CLA Signed label Aug 3, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 3, 2016

We want to be explicit. It’s unclear which tool would read a file called browserslist from the root folder. Somebody might delete it without realizing the consequence because search won’t show it’s imported anywhere.

We don’t really care about DRY here, we care about explicitness so you can see how everything in config ties together.

@kripod
Copy link
Contributor Author

kripod commented Aug 4, 2016

I updated the PR, trying my best to follow your great advices.

@gaearon gaearon merged commit 156a3c6 into facebook:master Aug 4, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 4, 2016

Thank you!

@gaearon gaearon assigned gaearon and unassigned gaearon Aug 4, 2016
@gaearon gaearon added this to the 0.3.0 milestone Aug 4, 2016
@kripod kripod deleted the #73 branch August 4, 2016 16:03
arunoda added a commit to storybookjs/storybook that referenced this pull request Aug 5, 2016
arunoda added a commit to storybookjs/storybook that referenced this pull request Aug 5, 2016
gaearon pushed a commit that referenced this pull request Aug 22, 2016
* Added a reasonable config for autoprefixer (resolves #73)

* Moved autoprefixer config to webpack.config
@gaearon gaearon modified the milestones: 0.2.2, 0.3.0 Aug 22, 2016
@gaearon gaearon mentioned this pull request Aug 22, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants