Upgrade chalk #2847
Closed
Upgrade chalk #2847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yeah, if we bump chalk we might as well do it everywhere! |
Contributor
Author
|
Done |
Contributor
|
Uh-oh. This broke 0.10 compat. |
Contributor
Author
|
I'm not sure what you mean by the node version check? Could you give a pointer on where and how it should be done? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade dependency to chalk@2.x.x for react-dev-utils which brings 256/Truecolor support and more, but more importantly it depends on
supports-colorhigher than 3.1.0 which brings browser support that enables webpack to not require the main file but the noop one making it compatible to webpack configs which disables node.process.This does not directly affect apps built with
create-react-app, but benefit those who require the utils fromreact-dev-utils.packages/react-scriptsandpackages/create-react-appalso use chalk and currently use the old version. If you want I could upgrade them as well.