Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some functions from paths.js into react-dev-utils/PathUtils #2446

Closed
wants to merge 1 commit into from

Conversation

ForbesLindesay
Copy link
Contributor

[see #2442]

This removes the path resolution utilities from config/paths.js and
leaves behind just the actual path configuration.

[see facebook#2442]

This removes the path resolution utilities from config/paths.js and
leaves behind just the actual path configuration.
@gaearon
Copy link
Contributor

gaearon commented Jun 27, 2017

Looks like CI is failing:

+npm run build
> @ build /home/travis/build/facebookincubator/create-react-app
> node packages/react-scripts/scripts/build.js
module.js:471
    throw err;
    ^
Error: Cannot find module '/home/travis/build/facebookincubator/create-react-app/packages/package.json'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at getPublicUrl (/home/travis/build/facebookincubator/create-react-app/packages/react-dev-utils/PathUtils.js:35:19)
    at Object.<anonymous> (/home/travis/build/facebookincubator/create-react-app/packages/react-scripts/config/paths.js:75:16)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)

@stale
Copy link

stale bot commented Nov 2, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the stale label Nov 2, 2018
@Timer Timer closed this Nov 2, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants