Improve error handling within e2e.sh #244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trapprovides more robust error handling thanset -e. (http://mywiki.wooledge.org/BashFAQ/105)This may actually fix #163. I was seeing a trapped error when I tried to replicate the state described in that issue, but it'd be helpful to have someone else confirm this.
I also point the npm test command to e2e.sh for convenience. Could go either way on that one. It's unimportant.
Error messages look like: