Disallow event global variable with no-restricted-globals rule (#1530) #1532
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -213,6 +213,7 @@ module.exports = { | |||
| // https://github.com/gajus/eslint-plugin-flowtype | |||
| 'flowtype/define-flow-type': 'warn', | |||
| 'flowtype/require-valid-file-annotation': 'warn', | |||
| 'flowtype/use-flow-type': 'warn' | |||
| 'flowtype/use-flow-type': 'warn', | |||
| 'no-restricted-globals': ['warn', 'event'] | |||
There was a problem hiding this comment.
I'm fine with this being an error, just like other undefined variables.
There was a problem hiding this comment.
yeah, make sense. I missed the fact that in a react app such use case make no sense, as opposite to bad practice in vanilla js.
|
(Tagging for 0.10 since it's technically a breaking change.) |
Fixes #1530