-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning from typescript-estree when building TypeScript app #7255
Comments
We've seen this, and @ianschmitz and I were discussing the best approach. We can a) turn off this error - but that sounds like the wrong approach, or b) pin the installed version of TypeScript on each release, so that it's within the range of that module. |
I find the error a bit intrusive. I mean this is where yarn's unmet peer dependency warnings are for right? |
Btw, typescript-estree is archived if I don't mismatch something. So locking TypeScript version in favor of unmaintained module doesn't seem a good idea rather than moving away from using archived modules. |
We use https://github.com/typescript-eslint/typescript-eslint - which has They now manage Keep in mind that we didn't create the error @rovansteen, and it's a default setting... so all we can do is either turn it off, or lock our versions and wait for them to make a release (which I assume would only ever be a few days later). https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/parser#configuration |
I know, was just saying that I don't think a package should just claim the console like that. I would be in favor of disabling the warning, but that would probably give more support for CRA if people encounter errors so locking the TypeScript version would make sense. |
@mrmckeb This is fixed since https://github.com/typescript-eslint/typescript-eslint/releases/tag/v1.10.1 |
EDITED |
you may use "resolutions": {
"@typescript-eslint/parser": "^1.11.0",
"@typescript-eslint/eslint-plugin": "^1.11.0"
} + |
We're working on upgrading these in the next version, we're just waiting for this: typescript-eslint/typescript-eslint#644 |
Seems to be fixed! |
This should be fixed in the next release :) |
ts 3.6.2 and it is back again. =( |
@lookfirst me too |
1 similar comment
@lookfirst me too |
Before any more #metoo, please just 👍 my comment, we all don't need more email. ❤️ 🙉 |
This comment has been minimized.
This comment has been minimized.
Is there any way to suppress this warning for the time being? I understand it and would like to just keep the logs a little bit quieter :) |
|
Upgrading typescript to 3.7.2 worked after removing bunch of |
Folks were likely seeing this because we previously had these packages pinned in our dependencies. We unpinned the We won't be supressing this warning at this point as it is an indication that you're using an unsupported version of TypeScript that can cause other issues with our tooling (such as linting). The ability to upgrade the |
Is this a bug report?
Yes
Did you try recovering your dependencies?
Yes
Which terms did you search for in User Guide?
N/A
Environment
Steps to Reproduce
yarn create react-app test --typescript
cd test
yarn build
Expected Behavior
A warning should not appear.
Actual Behavior
This warning appears:
This reported already here, and was marked fixed, but it's still happening.
Reproducible Demo
N/A
The text was updated successfully, but these errors were encountered: