Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose build manifest #600

Closed
gaearon opened this issue Sep 7, 2016 · 5 comments · Fixed by #891
Closed

Expose build manifest #600

gaearon opened this issue Sep 7, 2016 · 5 comments · Fixed by #891
Labels
contributions: up for grabs!
Milestone
100.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Sep 7, 2016

We should include an additional file as the build output. This file should contain a mapping of asset file names so that tools can pick it up without having to parse index.html. This is useful for integrations like this: http://myappincome.co.uk/how-to-make-a-react-js-wordpress-plugin/.

AFAIK Webpack already provides access to such object via its API, we just need to figure out how to write it to a file, and decide on the filename.
@scoland
Copy link

scoland commented Sep 8, 2016

Could we utilize something like this: https://www.npmjs.com/package/webpack-manifest-plugin?

@gaearon
Copy link
Contributor Author

gaearon commented Sep 8, 2016

Yep, something like this.

@gaearon gaearon added this to the 1.0.0 milestone Sep 30, 2016
@lukyth
Copy link
Contributor

lukyth commented Oct 11, 2016

Should we just use webpack-manifest-plugin on react-scripts/config/webpack.config.prod.js as @scoland have mentioned? And for the filename, I'd name it asset-manifest.json, since some user might already use manifest.json for their Web App Manifest already.

@gaearon
Copy link
Contributor Author

gaearon commented Oct 11, 2016

@lukyth Sounds reasonable.

lukyth added a commit to lukyth/create-react-app that referenced this issue Oct 11, 2016
@lukyth
Create asset filenames mapping on the build output
e2ca7a6 
I use danethurber/webpack-manifest-plugin on Webpack production
configuration to create a file named `asset-manifest.json` which contain a
mapping of all asset filenames to their corresponding output file.

`asset-manifest.json` will be located at the root of output folder.

This'll resolve facebook#600
@lukyth lukyth mentioned this issue Oct 11, 2016
Merged
gaearon pushed a commit that referenced this issue Oct 11, 2016
@lukyth @gaearon
Create asset filenames mapping on the build output (#891)
88c15d0 
* Create asset filenames mapping on the build output

I use danethurber/webpack-manifest-plugin on Webpack production
configuration to create a file named `asset-manifest.json` which contain a
mapping of all asset filenames to their corresponding output file.

`asset-manifest.json` will be located at the root of output folder.

This'll resolve #600

* Add an explanation for ManifestPlugin

* Make webpack-manifest-plugin's version exact
feiqitian pushed a commit to feiqitian/create-react-app that referenced this issue Oct 25, 2016
@lukyth @feiqitian
Create asset filenames mapping on the build output (facebook#891)
cf4b5e3 
* Create asset filenames mapping on the build output

I use danethurber/webpack-manifest-plugin on Webpack production
configuration to create a file named `asset-manifest.json` which contain a
mapping of all asset filenames to their corresponding output file.

`asset-manifest.json` will be located at the root of output folder.

This'll resolve facebook#600

* Add an explanation for ManifestPlugin

* Make webpack-manifest-plugin's version exact
jarlef pushed a commit to jarlef/create-react-app that referenced this issue Nov 28, 2016
@lukyth @jarlef
Create asset filenames mapping on the build output (facebook#891)
55a8d4c 
* Create asset filenames mapping on the build output

I use danethurber/webpack-manifest-plugin on Webpack production
configuration to create a file named `asset-manifest.json` which contain a
mapping of all asset filenames to their corresponding output file.

`asset-manifest.json` will be located at the root of output folder.

This'll resolve facebook#600

* Add an explanation for ManifestPlugin

* Make webpack-manifest-plugin's version exact
@ThorstenBruening
Copy link

Well done!

@viankakrisna viankakrisna mentioned this issue Feb 13, 2018
Merged
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: up for grabs!
Projects
None yet
Milestone
100.0
Development

Successfully merging a pull request may close this issue.

Create asset filenames mapping on the build output lukyth/create-react-app
4 participants
@gaearon @scoland @lukyth @ThorstenBruening