Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make launch editor a standalone package. #4091

Open
cpojer opened this issue Feb 28, 2018 · 7 comments
Open

Make launch editor a standalone package. #4091

cpojer opened this issue Feb 28, 2018 · 7 comments
Milestone

Comments

@cpojer
Copy link
Contributor

cpojer commented Feb 28, 2018

The launchEditor module is super useful: https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/launchEditor.js

I'd like to use it standalone, outside of create-react-app. Is there anyone willing to send a PR to make this a standalone package? :)

@egoist
Copy link

egoist commented Feb 28, 2018

@cpojer
Copy link
Contributor Author

cpojer commented Feb 28, 2018

Oh cool! Nevermind then – wondering why create-react-app isn't using this though.

@cpojer cpojer closed this as completed Feb 28, 2018
@SimenB
Copy link
Contributor

SimenB commented Feb 28, 2018

@Timer
Copy link
Contributor

Timer commented Feb 28, 2018

It looks like we added that file mere days after sindresorhus created his module, May 4th vs 14th so we probably didn't know about it.
launch-editor is extracted from our code base, so its effectively the same thing.

We should probably turn this into a module, it looks like open-editor doesn't have as much editor support and this would just be an official version of launch-editor.

@Timer Timer reopened this Feb 28, 2018
@Timer Timer added this to the 100.0.0 milestone Feb 28, 2018
@gaearon
Copy link
Contributor

gaearon commented Feb 28, 2018

wondering why create-react-app isn't using this though

I don't think @yyx990803 reached out to suggest extracting it before forking. We'd be happy to collab on this and keep it as a separate package.

@gaearon
Copy link
Contributor

gaearon commented Feb 28, 2018

(Didn't mean it in a bad way—I also fork a lot of stuff all the time because it takes time to establish relationships etc. But I'd be happy to give @yyx990803 commit rights in this repo and continue maintaining it here :-)

@yyx990803
Copy link
Contributor

yyx990803 commented Feb 28, 2018

Yeah, I just assumed create-react-app kept it inside react-dev-utils for a reason (like all the other utils in there) so didn't make that suggestion.

Another reason I forked it is mostly because I may need to make changes that make it incompatible with the needs of create-react-app. If you guys are happy with the current API of launch-editor I'd be happy to collaborate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants