-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make launch editor a standalone package. #4091
Comments
Oh cool! Nevermind then – wondering why create-react-app isn't using this though. |
It looks like we added that file mere days after sindresorhus created his module, May 4th vs 14th so we probably didn't know about it. We should probably turn this into a module, it looks like |
I don't think @yyx990803 reached out to suggest extracting it before forking. We'd be happy to collab on this and keep it as a separate package. |
(Didn't mean it in a bad way—I also fork a lot of stuff all the time because it takes time to establish relationships etc. But I'd be happy to give @yyx990803 commit rights in this repo and continue maintaining it here :-) |
Yeah, I just assumed Another reason I forked it is mostly because I may need to make changes that make it incompatible with the needs of |
The launchEditor module is super useful: https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/launchEditor.js
I'd like to use it standalone, outside of create-react-app. Is there anyone willing to send a PR to make this a standalone package? :)
The text was updated successfully, but these errors were encountered: