Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jsdom environment by default #3887

Closed
gaearon opened this issue Jan 21, 2018 · 4 comments
Closed

Use jsdom environment by default #3887

gaearon opened this issue Jan 21, 2018 · 4 comments
Labels
issue: proposal
Milestone
2.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Jan 21, 2018

See my comment in #3881 (comment). Everyone just leaves this flag in.

We should either make it the default, or ship tests that don’t rely on jsdom by default.
@gaearon gaearon added this to the 2.0.0 milestone Jan 21, 2018
@thymikee thymikee mentioned this issue Feb 2, 2018
Closed
@nickserv
Copy link
Contributor

nickserv commented Mar 31, 2018 •
edited
Loading

I disagree with changing the default, I think it should optimize for performance and boot up time by default, and many developers just need shallow rendering and won't realize JSDOM is being added unnecessarily. Though if it has to be changed can it please remain configurable?

@Timer
Copy link
Contributor

Timer commented Sep 24, 2018

See #5074

@Timer Timer closed this as completed Sep 24, 2018
@Azure2020
Copy link

Yes

@Azure2020
Copy link

I want to start with you. What is required off me?

@facebook facebook locked as off-topic and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: proposal
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@Timer @gaearon @nickserv @Azure2020