Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MDL checking #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable MDL checking #289

wants to merge 1 commit into from

Conversation

jaymzh
Copy link
Collaborator

@jaymzh jaymzh commented Feb 26, 2025

Had to change .mdl.rules - but should be compat with internal stuff.

@jaymzh
Copy link
Collaborator Author

jaymzh commented Feb 26, 2025

Converting to draft while Meta internally sorts out the config files.

The style file was incorrectly opensourced as the rc file which won't work. That needs to be renamed, and the appropriate rc file opensourced. Once that's sorted this will work properly.

@dafyddcrosby
Copy link
Contributor

Should work after rebasing onto d1e9d69

@jaymzh
Copy link
Collaborator Author

jaymzh commented Mar 25, 2025

@dafyddcrosby - rebased, but I think your config isn't compatible with a newer version of MDL. I can update it to use the bundle version instead of the one from Actions, if you'd like.

@jaymzh jaymzh force-pushed the mdl branch 2 times, most recently from bf6111b to 0501e84 Compare March 26, 2025 01:50
Signed-off-by: Phil Dibowitz <phil@ipom.com>
@jaymzh jaymzh marked this pull request as ready for review March 26, 2025 01:54
@jaymzh jaymzh requested a review from dafyddcrosby March 26, 2025 01:55
@facebook-github-bot
Copy link
Contributor

@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants