Repository navigation
fix(cli): correct Dialog onClose → onOpenChange in styling docs - #5605
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
PR Analysis Report📚 Storybook PreviewView Storybook for this PR 🧪 Sandbox PreviewView Sandbox for this PR No new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
cixzhang
commented
Sep 3, 2026
cixzhang
left a comment
Contributor
Author
There was a problem hiding this comment.
Semantic verdict: approve
Thanks, this fixes the styling example so builders copy the Dialog prop that actually compiles.
[Reviewed by Robohands]
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Compound Components" code example in the styling CLI doc (
astryx docs styling) used the deprecatedonCloseprop on<Dialog>. The correct prop isonOpenChange(unified in v0.0.2 via theunify-visibility-to-onOpenChangecodemod).Agents discovering the API via
npx astryx docs stylingwould see:…and produce TS2322 because
onClosedoesn't exist onDialogProps.Fix
onClose→onOpenChangein the code example. One-line change.Evidence (vibe test 2026-08-27)
Before (nightly run, unfixed
origin/main):wd-4failed in both Astryx iteration588bb19band Astryx+TW iteration491de8f1with identical error:After (fixed worktree):
npx astryx docs stylingnow outputsonOpenChange={close}(verified via CLI output).onOpenChange— no conflict between component doc and styling doc.Risk
None. Documentation-only change to a code example. No component behavior or type change.