Fix the vpdq error #1692
Open
Fix the vpdq error #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dcallies
requested changes
Nov 9, 2024
There was a problem hiding this comment.
Hey @ZeyadTarekk , can you explain how you know that this fixes the problem?
Usually I expect the exact steps that show it is broken before and fixed after in the test plan, but yours doesn't have enough detail for me to tell.
|
@Dcallies Because that was the message in the error |
|
Hey Zeyad, can you include in your summary/test plan:
The screenshot you have provided isn't enough details to tell me that this PR will fix the entire problem you are seeing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solve #1691
Test Plan
Solve #1691