Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds failing because of invalid icon specified in id-tagging-schema repo #474

Open
bhousel opened this issue May 12, 2022 · 0 comments
Open
Labels
chore Improvements to the code or development stack, cleanups

Comments

@bhousel
Copy link
Contributor

bhousel commented May 12, 2022

The error we're seeing is this one:

🏗   Building data...
Error: No FontAwesome icon for fas-cart-shopping
TypeError: Cannot read properties of undefined (reading 'html')
    at file:///Users/bryan/Projects/RapiD/scripts/build_data.js:236:75
    at Array.forEach (<anonymous>)
    at writeFaIcons (file:///Users/bryan/Projects/RapiD/scripts/build_data.js:231:23)
    at file:///Users/bryan/Projects/RapiD/scripts/build_data.js:121:7
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Promise.all (index 10)

ERROR: "build:data" exited with 1.

The fas-cart-shopping icon does not seem to appear in the FontAwesome dependency.
The icon was introduced in this commit

This now affects our build because of these lines:
https://github.com/facebookincubator/RapiD/blob/6070b2e531fff92f8bdc2a8d44c1093df0c60328/scripts/build_data.js#L102-L106

I was surprised to find that we are actually fetching these icons at build time, rather than just using the already installed dependency.

For today to get the builds working again, I'm going to comment out these lines, but going forward we should think about reducing our dependency on the id-tagging-schema project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Improvements to the code or development stack, cleanups
Projects
None yet
Development

No branches or pull requests

1 participant