Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid coincident detections #1516

Closed
bhousel opened this issue Aug 15, 2024 · 0 comments
Closed

Avoid coincident detections #1516

bhousel opened this issue Aug 15, 2024 · 0 comments
Assignees
@bhousel
Labels
feature-streetview Issue or request related to the streetview viewer feature-usability Issue or feature related to usability - something hard to do
Milestone
v2.4

Comments

@bhousel
Copy link
Contributor

bhousel commented Aug 15, 2024

We have some code in other parts of Rapid that will detect if multiple things are in exactly the same place ("coincident"), and spread them out slightly so the user can see and select them. We should probably do this for detections too.

In this situation the "No Left Turn" marker is obscuring the "Stop" marker.
I can kind of see why it got detected this way from the picture, it just makes the detections difficult to work with.

Screenshot 2024-08-15 at 11 24 10 AM
@bhousel bhousel self-assigned this Aug 15, 2024
@bhousel bhousel added feature-usability Issue or feature related to usability - something hard to do feature-streetview Issue or request related to the streetview viewer labels Aug 15, 2024
@bhousel bhousel added this to the v2.4 milestone Aug 17, 2024
bhousel added a commit that referenced this issue Aug 17, 2024
@bhousel
Update the _preventCoincident functions, use 'rbush' consistently
83a0d76 
(closes #1516)

- This adds `_preventCoincident` to the Mapillary detections to avoid
  markers appearing on top of one another.
- Also simplifies the `_preventCoincident` function that we use in
  various places (Mapillary, Osmose, KeepRight) - it just moves down now.
- Also consistently use the word "rbush" for these spatial caches.
  Previously, our code had a mix of "rbush" and "rtree" in different places.
  But the library we use is RBush, so we will call it that.
bhousel added a commit that referenced this issue Aug 18, 2024
@bhousel
Update the _preventCoincident functions, use 'rbush' consistently
4af8069 
(closes #1516)

- This adds `_preventCoincident` to the Mapillary detections to avoid
  markers appearing on top of one another.
- Also simplifies the `_preventCoincident` function that we use in
  various places (Mapillary, Osmose, KeepRight) - it just moves down now.
- Also consistently use the word "rbush" for these spatial caches.
  Previously, our code had a mix of "rbush" and "rtree" in different places.
  But the library we use is RBush, so we will call it that.
@bhousel bhousel mentioned this issue Aug 28, 2024
Merged
@bhousel bhousel mentioned this issue Sep 9, 2024
Open
bhousel added a commit that referenced this issue Sep 11, 2024
@bhousel
Store detections and signs in the same cache
74758b6 
(closes #1538)

Before, by having them in different caches, it was possible for a point detection and
a sign detection to be in the same place (which we were trying to avoid with #1516)

Now by putting them in the same cache, the code that prevents coincident
detections can work to keep them spread a little bit apart.
@bhousel bhousel mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhousel bhousel

Labels
feature-streetview Issue or request related to the streetview viewer feature-usability Issue or feature related to usability - something hard to do
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
1 participant
@bhousel