Make transition_to non-optional for TC

[mgarrard]

Summary:
Enforce transition_to as a required argument in TransitionCriterion

This diff makes transition_to a required argument in the TransitionCriterion class. It updates the MinimumPreferenceOccurances and MinTrials classes to include transition_to as a required argument. The GenerationNode class is also updated to include a placeholder_transition_to attribute, which will be overwritten in the GenerationStrategy constructor.

The changes include:

• Updated MinimumPreferenceOccurances and MinTrials classes to require transition_to argument
• Added placeholder_transition_to attribute to GenerationNode class
• Updated unit tests to reflect the changes

With this change, users will be required to provide a transition_to argument when creating a TransitionCriterion object. This ensures that the GenerationStrategy knows which generation node to transition to when a criterion is met.

Reviewed By: lena-kashtelyan

Differential Revision: D91141100

[meta-codesync]

@mgarrard has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91141100.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.75%. Comparing base (6a4a3b5) to head (0788715).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4848   +/-   ##
=======================================
  Coverage   96.75%   96.75%           
=======================================
  Files         590      590           
  Lines       61716    61719    +3     
=======================================
+ Hits        59711    59714    +3     
  Misses       2005     2005           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.