Let DerivedParameter support bool and str types for simple copies
#4847
+211
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SebastianAment has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92062866. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4847 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 590 590
Lines 61716 61791 +75
=======================================
+ Hits 59711 59788 +77
+ Misses 2005 2003 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 3, 2026
…es (facebook#4847) Summary: This commit adds support for DerivedParameters with `bool` and `str` types, if the expression consists of a single parameter, equivalent to a simple copy operation. Reviewed By: sunnyshen321 Differential Revision: D92062866
SebastianAment
force-pushed
the
export-D92062866
branch
from
cbe5b57 to
e9eb323
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 3, 2026
…es (facebook#4847) Summary: This commit adds support for DerivedParameters with `bool` and `str` types, if the expression consists of a single parameter, equivalent to a simple copy operation. Reviewed By: sunnyshen321 Differential Revision: D92062866
SebastianAment
force-pushed
the
export-D92062866
branch
from
e9eb323 to
ae292f3
Compare
…es (facebook#4847) Summary: This commit adds support for DerivedParameters with `bool` and `str` types, if the expression consists of a single parameter, equivalent to a simple copy operation. Reviewed By: sunnyshen321 Differential Revision: D92062866
SebastianAment
force-pushed
the
export-D92062866
branch
from
ae292f3 to
a08cd92
Compare
|
This pull request has been merged in ef35f71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit adds support for DerivedParameters with
boolandstrtypes, if the expression consists of a single parameter, equivalent to a simple copy operation.Reviewed By: sunnyshen321
Differential Revision: D92062866