Explicit int cast for trial_index #4846
Closed
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: f1028514505 failed bc we weren't able to attach data as data indices were `str` type. This is because 1. At Load: pd.read_json(StringIO(data_sqa.data_json), dtype=False) -- no type enforcement https://fburl.com/code/2emkm30n 2. At data construction, although we have `trial_index=row.trial_index` and RowData have int type hint for trial_index, it is not enforced at run time. Putting up a diff to explicitly cast trial index to int {F1985100756} Reviewed By: mpolson64 Differential Revision: D91949517
meta-cla
bot
added
the
CLA Signed
|
@sunnyshen321 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91949517. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4846 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 590 590
Lines 61704 61706 +2
=======================================
+ Hits 59698 59700 +2
Misses 2006 2006 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 67b2179. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
f1028514505 failed bc we weren't able to attach data as data indices were
strtype. This is becausetrial_index=row.trial_indexand RowData have int type hint for trial_index, it is not enforced at run time.Putting up a diff to explicitly cast trial index to int
{F1985100756}
Reviewed By: mpolson64
Differential Revision: D91949517