Skip to content

Conversation

@jandylin
Copy link

Summary:
The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space.

This change implements a hierarchical approach with priorities:
(1) status_quo values if available and within the search space
(2) best trial values for single-objective optimization
(3) search space center as the final fallback

The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency.

Differential Revision: D91920684

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 30, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 30, 2026

@jandylin has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91920684.

jandylin pushed a commit to jandylin/Ax that referenced this pull request Jan 30, 2026
)

Summary:

The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space.

This change implements a hierarchical approach with priorities:
(1) status_quo values if available and within the search space
(2) best trial values for single-objective optimization
(3) search space center as the final fallback

The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency.

Differential Revision: D91920684
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 97.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.74%. Comparing base (714f2f1) to head (c76e42a).

Files with missing lines Patch % Lines
ax/analysis/plotly/surface/utils.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4841      +/-   ##
==========================================
- Coverage   96.74%   96.74%   -0.01%     
==========================================
  Files         589      590       +1     
  Lines       61623    61692      +69     
==========================================
+ Hits        59620    59685      +65     
- Misses       2003     2007       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jandylin pushed a commit to jandylin/Ax that referenced this pull request Jan 30, 2026
)

Summary:

The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space.

This change implements a hierarchical approach with priorities:
(1) status_quo values if available and within the search space
(2) best trial values for single-objective optimization
(3) search space center as the final fallback

The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency.

Reviewed By: sdaulton

Differential Revision: D91920684
jandylin pushed a commit to jandylin/Ax that referenced this pull request Jan 30, 2026
)

Summary:

The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space.

This change implements a hierarchical approach with priorities:
(1) status_quo values if available and within the search space
(2) best trial values for single-objective optimization
(3) search space center as the final fallback

The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency.

Reviewed By: sdaulton

Differential Revision: D91920684
)

Summary:

The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space.

This change implements a hierarchical approach with priorities:
(1) status_quo values if available and within the search space
(2) best trial values for single-objective optimization
(3) search space center as the final fallback

The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency.

Reviewed By: sdaulton

Differential Revision: D91920684
jandylin pushed a commit to jandylin/Ax that referenced this pull request Feb 2, 2026
)

Summary:

The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space.

This change implements a hierarchical approach with priorities:
(1) status_quo values if available and within the search space
(2) best trial values for single-objective optimization
(3) search space center as the final fallback

The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency.

Reviewed By: sdaulton

Differential Revision: D91920684
@jandylin jandylin force-pushed the export-D91920684 branch 2 times, most recently from cf09413 to 46d91b5 Compare February 2, 2026 15:47
@meta-codesync meta-codesync bot closed this in 0d801f4 Feb 2, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 2, 2026

This pull request has been merged in 0d801f4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants