-
Notifications
You must be signed in to change notification settings - Fork 358
Improve fixed parameter selection for slice/contour plots #4841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandylin
pushed a commit
to jandylin/Ax
that referenced
this pull request
Jan 30, 2026
) Summary: The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space. This change implements a hierarchical approach with priorities: (1) status_quo values if available and within the search space (2) best trial values for single-objective optimization (3) search space center as the final fallback The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency. Differential Revision: D91920684
0bdd92a to
e6ed139
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4841 +/- ##
==========================================
- Coverage 96.74% 96.74% -0.01%
==========================================
Files 589 590 +1
Lines 61623 61692 +69
==========================================
+ Hits 59620 59685 +65
- Misses 2003 2007 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jandylin
pushed a commit
to jandylin/Ax
that referenced
this pull request
Jan 30, 2026
) Summary: The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space. This change implements a hierarchical approach with priorities: (1) status_quo values if available and within the search space (2) best trial values for single-objective optimization (3) search space center as the final fallback The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency. Reviewed By: sdaulton Differential Revision: D91920684
e6ed139 to
afb7180
Compare
jandylin
pushed a commit
to jandylin/Ax
that referenced
this pull request
Jan 30, 2026
) Summary: The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space. This change implements a hierarchical approach with priorities: (1) status_quo values if available and within the search space (2) best trial values for single-objective optimization (3) search space center as the final fallback The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency. Reviewed By: sdaulton Differential Revision: D91920684
afb7180 to
c76e42a
Compare
) Summary: The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space. This change implements a hierarchical approach with priorities: (1) status_quo values if available and within the search space (2) best trial values for single-objective optimization (3) search space center as the final fallback The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency. Reviewed By: sdaulton Differential Revision: D91920684
jandylin
pushed a commit
to jandylin/Ax
that referenced
this pull request
Feb 2, 2026
) Summary: The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space. This change implements a hierarchical approach with priorities: (1) status_quo values if available and within the search space (2) best trial values for single-objective optimization (3) search space center as the final fallback The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency. Reviewed By: sdaulton Differential Revision: D91920684
cf09413 to
46d91b5
Compare
|
This pull request has been merged in 0d801f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Do not delete this pull request or issue due to inactivity.
fb-exported
Merged
meta-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The previous implementation always fixed other parameters to the center of the search space when generating slice and contour plots (although the documentation claims it would use status_quo values). This could produce suboptimal visualizations that don't reflect the most interesting region of the parameter space.
This change implements a hierarchical approach with priorities:
(1) status_quo values if available and within the search space
(2) best trial values for single-objective optimization
(3) search space center as the final fallback
The plots now also display which source was used and the actual fixed parameter values in the subtitle for transparency.
Differential Revision: D91920684