Deprecate default_data_type argument to Experiment #4698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@esantorella has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89744225. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4698 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 580 580
Lines 60714 60697 -17
=======================================
- Hits 58708 58693 -15
+ Misses 2006 2004 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…a_type (facebook#4691) Summary: Pull Request resolved: facebook#4691 **Context:** `default_data_constructor` and `default_data_type` are used for a few purposes: 1. Determining the type of empty data 2. Determining the type of data that results from combining multiple `Data`s 3. Validating that observations passed match the `default_data_type` on the experiment Now that we have reduced our data classes down to just `Data` and `MapData`, and there is only one map key, and those two classes now differ mainly in whether they have a "step" column, there is little reason to worry so much about tracking the intended type of data. This PR brings us closer to unifying Data and MapData, because with this change, it should always be the case that a data is a MapData if and only if it has a "step" column; thus, there is no information contained in the class that can't be obtained by chacking whether there is a "step" column. **This PR:** 1. Makes empty data `Data` 2a. When combining multiple datas, the result is MapData if one of the constituent objects is a MapData. 2b. When making a Data from a DataFrame, it should be a MapData if there is a "step" column 3. Removes some validations that are no longer necessary * Removes `Experiment._default_data_type` * Removes `Experiment.default_data_type` * Removes `Experiment.default_data_constructor` **Some TODOs for follow-up diffs:** * Deprecate or remove `default_data_type` argument to experiment * Remove `Metric.data_constructor` (if needed, replacing it with a boolean attribute indicating whether a progression will be produced) * Convert some `Metric` methods such as `_unwrap_experiment_data` into static methods or move them off `Metric` entirely now that they do not reference the `data_constructor` attribute Differential Revision: D89689313 Privacy Context Container: L1307644 Reviewed By: lena-kashtelyan
esantorella
force-pushed
the
export-D89744225
branch
from
b1e46a4 to
44e1745
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Dec 26, 2025
Summary: Pull Request resolved: facebook#4698 Or we could just remove it, since it's non-API... Reviewed By: lena-kashtelyan Differential Revision: D89744225
Summary: Pull Request resolved: facebook#4698 Or we could just remove it, since it's non-API... Reviewed By: lena-kashtelyan Differential Revision: D89744225
esantorella
force-pushed
the
export-D89744225
branch
from
44e1745 to
3ae5321
Compare
|
This pull request has been merged in 64570ba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Or we could just remove it, since it's non-API...
Differential Revision: D89744225