Fix dependent handling in Log transform #4679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ok#4678) Summary: Fixes dependent handling in `TaskChoiceToIntTaskChoice` by removing custom implementation of parent methods, which handle dependents correctly. Differential Revision: D89405149 Privacy Context Container: L1307644
Summary: `Log` transform was ignoring `dependents` attribute of the `ChoiceParameters` being transformed. This hasn't been an issue so far since we did not support >2 values in HSS GS, but we should fix it for future usage. This diff transforms the dependents in the same way it transforms the parameter values. Differential Revision: D89405948 Privacy Context Container: L1307644
meta-cla
bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89405948. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Dec 17, 2025
Summary: `Log` transform was ignoring `dependents` attribute of the `ChoiceParameters` being transformed. This hasn't been an issue so far since we did not support >2 values in HSS GS, but we should fix it for future usage. This diff transforms the dependents in the same way it transforms the parameter values. Differential Revision: D89405948 Privacy Context Container: L1307644
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Dec 17, 2025
Summary: `Log` transform was ignoring `dependents` attribute of the `ChoiceParameters` being transformed. This hasn't been an issue so far since we did not support >2 values in HSS GS, but we should fix it for future usage. This diff transforms the dependents in the same way it transforms the parameter values. Differential Revision: D89405948 Privacy Context Container: L1307644
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4679 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 568 568
Lines 58960 58951 -9
=======================================
- Hits 56910 56902 -8
+ Misses 2050 2049 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in ca1368e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Logtransform was ignoringdependentsattribute of theChoiceParametersbeing transformed. This hasn't been an issue so far since we did not support >2 values in HSS GS, but we should fix it for future usage.This diff transforms the dependents in the same way it transforms the parameter values.
Differential Revision:
D89405948
Privacy Context Container: L1307644