Deprecate Tensorboard metrics' percentile in favor of quantile and add validation
#4676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@SebastianAment has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89398190. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4676 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 568 568
Lines 58960 59015 +55
=======================================
+ Hits 56910 56965 +55
Misses 2050 2050 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…d add validation (facebook#4676) Summary: This diff deprecates `percentile` in favor of `quantile`, since the actual behavior of `percentile` is that of a quantile. Reviewed By: bernardbeckerman Differential Revision: D89398190
SebastianAment
force-pushed
the
export-D89398190
branch
from
a599076 to
b0a3215
Compare
|
This pull request has been merged in 6662506. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff deprecates
percentilein favor ofquantile, since the actual behavior ofpercentileis that of a quantile.Differential Revision: D89398190