Rename model_cv_kwargs -> cv_kwargs #4669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89321564. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4669 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 568 568
Lines 58960 58973 +13
=======================================
+ Hits 56910 56924 +14
+ Misses 2050 2049 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: As titled. JSON storage is updated to support loading arguments serialized with the old name. There is no direct SQA storage for these fields (serialized through JSONified GeneratorSpec / GenerationStep) Differential Revision: D89299127
Summary: Pull Request resolved: facebook#4668 Selectively renames `model_kwargs -> generator_kwargs`: - Was previously renamed for `GeneratorRun`. - Renames `GenerationStep` input and attributes. - Renames `GeneratorSpec` input and attributes. - `GeneratorSpec.fit` `**model_kwargs` input to `**generator_kwargs`, and also in a couple helper methods that used the same naming. - Updates miscellaneous usage within dispatching layer as argument names etc. Updates JSON storage to support loading both new and old arguments. No SQA storage updates needed, since these objects are serialized through their JSONinifed counterparts. In addition, renames: - `_DEPRECATED_MODEL_TO_REPLACEMENT -> _DEPRECATED_GENERATOR_TO_REPLACEMENT` - `_DEPRECATED_MODEL_KWARGS -> _DEPRECATED_GENERATOR_KWARGS` - `GeneratorRegistryBase._get_model_kwargs` and `_get_bridge_kwargs` (leftover from previous diff) Backwards compatibility for GStep & GSpec inputs are added later in the stack to ensure that this diff updates all internal usage. Differential Revision: D89313576 Reviewed By: Balandat
Summary: Pull Request resolved: facebook#4669 This should be one of the last usages (if not the last!) of "model" terminology in high level surfaces. Updated JSON storage to support deserializing both new and old arguments. No SQA storage updates are needed. Differential Revision: D89321564 Privacy Context Container: L1307644
saitcakmak
force-pushed
the
export-D89321564
branch
from
f962595 to
927cf4c
Compare
|
This pull request has been merged in 75f6058. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This should be one of the last usages (if not the last!) of "model" terminology in high level surfaces.
Updated JSON storage to support deserializing both new and old arguments. No SQA storage updates are needed.
Differential Revision:
D89321564
Privacy Context Container: L1307644