Skip to content

Conversation

@saitcakmak
Copy link
Contributor

Summary:
As titled. JSON storage is updated to support loading arguments serialized with the old name. There is no direct SQA storage for these fields (serialized through JSONified GeneratorSpec / GenerationStep)

Backwards compatibility for GStep & GSpec inputs are added later in the stack to ensure that this diff updates all internal usage.

Differential Revision: D89299127

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 16, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 16, 2025

@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89299127.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.52%. Comparing base (b72fdf9) to head (229e00c).

Files with missing lines Patch % Lines
ax/generation_strategy/generation_node.py 87.50% 1 Missing ⚠️
...ion_strategy/generation_node_input_constructors.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4667   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files         568      568           
  Lines       58960    58966    +6     
=======================================
+ Hits        56910    56917    +7     
+ Misses       2050     2049    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

saitcakmak added a commit to saitcakmak/Ax that referenced this pull request Dec 17, 2025
Summary:

As titled. JSON storage is updated to support loading arguments serialized with the old name. There is no direct SQA storage for these fields (serialized through JSONified GeneratorSpec / GenerationStep)

Backwards compatibility for GStep & GSpec inputs are added later in the stack to ensure that this diff updates all internal usage.

Reviewed By: Balandat

Differential Revision: D89299127
Summary:

As titled. JSON storage is updated to support loading arguments serialized with the old name. There is no direct SQA storage for these fields (serialized through JSONified GeneratorSpec / GenerationStep)

Backwards compatibility for GStep & GSpec inputs are added later in the stack to ensure that this diff updates all internal usage.

Reviewed By: Balandat

Differential Revision: D89299127
@meta-codesync
Copy link

meta-codesync bot commented Dec 17, 2025

This pull request has been merged in 3d2ad4a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants