Skip to content

Conversation

@ltiao
Copy link
Contributor

@ltiao ltiao commented Dec 9, 2025

Summary: NaN values in the progression column (MAP_KEY) cause align_partial_results to throw an exception that is silently caught, preventing early stopping from functioning. This change drops NaN rows early in _lookup_and_validate_data and logs a warning to alert users of potentially corrupted or missing progression data.

Differential Revision: D88750798

Summary: NaN values in the progression column (MAP_KEY) cause `align_partial_results` to throw an exception that is silently caught, preventing early stopping from functioning. This change drops NaN rows early in `_lookup_and_validate_data` and logs a warning to alert users of potentially corrupted or missing progression data.

Differential Revision: D88750798
@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 9, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 9, 2025

@ltiao has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88750798.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.53%. Comparing base (6cfd488) to head (c8b1b0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4634      +/-   ##
==========================================
- Coverage   96.53%   96.53%   -0.01%     
==========================================
  Files         561      561              
  Lines       58175    58200      +25     
==========================================
+ Hits        56161    56185      +24     
- Misses       2014     2015       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meta-codesync
Copy link

meta-codesync bot commented Dec 9, 2025

This pull request has been merged in b092b4d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants