Fix bug where StandardizeY doesn't update the weights in ScalarizedObjective #4619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
dme65
force-pushed
the
export-D88378887
branch
2 times, most recently
from
a4bbd82 to
12027c1
Compare
dme65
pushed a commit
to dme65/Ax
that referenced
this pull request
Dec 4, 2025
…jective (facebook#4619) Summary: This diff addresses an issue where the `StandardizeY` transform currently doesn't update the weights in `ScalarizedObjective`. When standardizing a `ScalarizedObjective`, the weights need to be multiplied by the standard deviation of each metric. Reviewed By: saitcakmak Differential Revision: D88378887
dme65
force-pushed
the
export-D88378887
branch
from
12027c1 to
41dce4c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4619 +/- ##
=======================================
Coverage 96.51% 96.52%
=======================================
Files 561 561
Lines 58020 58052 +32
=======================================
+ Hits 56000 56032 +32
Misses 2020 2020 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…jective (facebook#4619) Summary: This diff addresses an issue where the `StandardizeY` transform currently doesn't update the weights in `ScalarizedObjective`. When standardizing a `ScalarizedObjective`, the weights need to be multiplied by the standard deviation of each metric. Reviewed By: saitcakmak Differential Revision: D88378887
dme65
force-pushed
the
export-D88378887
branch
from
41dce4c to
ca6a648
Compare
|
This pull request has been merged in 436cfeb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff addresses an issue where the
StandardizeYtransform currently doesn't update the weights inScalarizedObjective. When standardizing aScalarizedObjective, the weights need to be multiplied by the standard deviation of each metric.Reviewed By: saitcakmak
Differential Revision: D88378887