Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ax/api/utils/instantiation/from_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ def parameter_from_config(
"step_size."
)

if (upper - lower) % step_size != 0:
remainder = (upper - lower) % step_size
# Use tolerance-based comparison to handle floating point precision issues
if not np.isclose(remainder, 0) and not np.isclose(remainder, step_size):
raise UserInputError(
"The range of the parameter must be evenly divisible by the "
"step size."
Expand Down
28 changes: 28 additions & 0 deletions ax/api/utils/instantiation/tests/test_from_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,34 @@ def test_create_range_parameter(self) -> None:
),
)

fractional_step_size_config = RangeParameterConfig(
name="fractional_step_size_param",
parameter_type="float",
bounds=(0, 1),
step_size=0.1,
)
self.assertEqual(
parameter_from_config(config=fractional_step_size_config),
ChoiceParameter(
name="fractional_step_size_param",
parameter_type=CoreParameterType.FLOAT,
values=[
0.0,
0.1,
0.2,
0.3,
0.4,
0.5,
0.6,
0.7,
0.8,
0.9,
1.0,
],
is_ordered=True,
),
)

with self.assertRaisesRegex(
UserInputError,
"Non-linear parameter scaling is not supported when using step_size",
Expand Down
2 changes: 1 addition & 1 deletion ax/core/parameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ def _get_default_sort_values_and_warn(self) -> bool:
f'`sort_values` is not specified for `ChoiceParameter` "{self._name}". '
f"Defaulting to `{default_bool}` for parameters of `ParameterType` "
f"{self.parameter_type.name}. To override this behavior (or avoid this "
f"warning), specify `sort_values` during `ChoiceParameter` "
"warning), specify `sort_values` during `ChoiceParameter` "
"construction.",
AxParameterWarning,
stacklevel=3,
Expand Down