Enforce sort_values=True for numeric ordered ChoiceParameter #4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Numeric ordered choice parameters should always have sorted values since the ordering is based on their numerical values. This change adds validation to enforce `sort_values=True` for numeric ordered parameters and suppresses the warning since the value is now required rather than optional. This simplifies downstream handling of choice parameters, such as in (yet to be implemented for choice) expansion of the model space in `Adapter` using points observed in previous trials. The fewer options we have, the easier it will be to support new features. Reviewed By: dme65 Differential Revision: D87903513
meta-cla
bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87903513. |
|
This pull request has been merged in f0d4594. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Numeric ordered choice parameters should always have sorted values since the ordering is based on their numerical values. This change adds validation to enforce
sort_values=Truefor numeric ordered parameters and suppresses the warning since the value is now required rather than optional.This simplifies downstream handling of choice parameters, such as in (yet to be implemented for choice) expansion of the model space in
Adapterusing points observed in previous trials. The fewer options we have, the easier it will be to support new features.Reviewed By: dme65
Differential Revision: D87903513