Support ChoiceParameter in Log transform #4592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87233844. |
meta-cla
bot
added
the
CLA Signed
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Nov 26, 2025
Summary: Adds support for log-transforming log-scale choice parameters. NOTE: This is irrelevant if we're using `OrderedChoiceToIntegerRange` transform (since it will become range, ignoring the log-scale input). It will make a difference if we use `ChoiceToNumericChoice`. Differential Revision: D87233844
Summary: Adds support for log-scale modeling to ChoiceParameter. By default, any numeric choice parameter that demonstrates exponentially scaled values (2, 4, 8, 16, 32, ...) will set `log_scale=True`. Both SQA & JSON storage is updated to write & read the new field, mirrored after the logic for RangeParameter. Next diff will add support for this in Log-transform. NOTE: This is irrelevant if we're using `OrderedChoiceToIntegerRange` transform (since it will become range, ignoring the log-scale input). It will make a difference if we use `ChoiceToNumericChoice`. Reviewed By: mpolson64 Differential Revision: D87233839
Summary: Adds support for log-transforming log-scale choice parameters. NOTE: This is irrelevant if we're using `OrderedChoiceToIntegerRange` transform (since it will become range, ignoring the log-scale input). It will make a difference if we use `ChoiceToNumericChoice`. Reviewed By: dme65 Differential Revision: D87233844
saitcakmak
force-pushed
the
export-D87233844
branch
from
8980102 to
127aa61
Compare
|
This pull request has been merged in 73893ee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds support for log-transforming log-scale choice parameters.
NOTE: This is irrelevant if we're using
OrderedChoiceToIntegerRangetransform (since it will become range, ignoring the log-scale input). It will make a difference if we useChoiceToNumericChoice.Differential Revision: D87233844