Skip to content

Conversation

@eonofrey
Copy link
Contributor

Summary: As titled, we believe IndividualConstraintsFeasibilityAnalysis is strictly better than ConstraintsFeasibilityAnalysis in all aspects but name, so we are naming the former ConstraintsFeasibilityAnalysis and deleting the latter

Differential Revision: D86808454

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 11, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 11, 2025

@eonofrey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86808454.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 96.89922% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.55%. Comparing base (59fe591) to head (e6cd44c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ax/analysis/healthcheck/constraints_feasibility.py 93.44% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4527      +/-   ##
==========================================
- Coverage   96.56%   96.55%   -0.01%     
==========================================
  Files         552      550       -2     
  Lines       57139    57021     -118     
==========================================
- Hits        55178    55059     -119     
- Misses       1961     1962       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

eonofrey added a commit to eonofrey/Ax that referenced this pull request Nov 12, 2025
…easibilityAnalysis` (facebook#4527)

Summary:

As titled, we believe `IndividualConstraintsFeasibilityAnalysis` is strictly better than `ConstraintsFeasibilityAnalysis` in all aspects but name, so we are naming the former `ConstraintsFeasibilityAnalysis` and deleting the latter

Differential Revision: D86808454
eonofrey added a commit to eonofrey/Ax that referenced this pull request Nov 12, 2025
…easibilityAnalysis` (facebook#4527)

Summary:

As titled, we believe `IndividualConstraintsFeasibilityAnalysis` is strictly better than `ConstraintsFeasibilityAnalysis` in all aspects but name, so we are naming the former `ConstraintsFeasibilityAnalysis` and deleting the latter

Differential Revision: D86808454
eonofrey added a commit to eonofrey/Ax that referenced this pull request Nov 17, 2025
…easibilityAnalysis` (facebook#4527)

Summary:

As titled, we believe `IndividualConstraintsFeasibilityAnalysis` is strictly better than `ConstraintsFeasibilityAnalysis` in all aspects but name, so we are naming the former `ConstraintsFeasibilityAnalysis` and deleting the latter

Differential Revision: D86808454
@eonofrey eonofrey force-pushed the export-D86808454 branch 2 times, most recently from 2375a96 to 1fdc99c Compare November 20, 2025 16:45
eonofrey added a commit to eonofrey/Ax that referenced this pull request Nov 20, 2025
…easibilityAnalysis` (facebook#4527)

Summary:

As titled, we believe `IndividualConstraintsFeasibilityAnalysis` is strictly better than `ConstraintsFeasibilityAnalysis` in all aspects but name, so we are naming the former `ConstraintsFeasibilityAnalysis` and deleting the latter

Differential Revision: D86808454
eonofrey added a commit to eonofrey/Ax that referenced this pull request Nov 20, 2025
…easibilityAnalysis` (facebook#4527)

Summary:

As titled, we believe `IndividualConstraintsFeasibilityAnalysis` is strictly better than `ConstraintsFeasibilityAnalysis` in all aspects but name, so we are naming the former `ConstraintsFeasibilityAnalysis` and deleting the latter

Differential Revision: D86808454
eonofrey added a commit to eonofrey/Ax that referenced this pull request Nov 20, 2025
…easibilityAnalysis` (facebook#4527)

Summary:

As titled, we believe `IndividualConstraintsFeasibilityAnalysis` is strictly better than `ConstraintsFeasibilityAnalysis` in all aspects but name, so we are naming the former `ConstraintsFeasibilityAnalysis` and deleting the latter

Differential Revision: D86808454
@eonofrey eonofrey force-pushed the export-D86808454 branch 2 times, most recently from d4fe7c3 to e6cd44c Compare November 24, 2025 22:19
eonofrey added a commit to eonofrey/Ax that referenced this pull request Nov 24, 2025
…easibilityAnalysis` (facebook#4527)

Summary:

As titled, we believe `IndividualConstraintsFeasibilityAnalysis` is strictly better than `ConstraintsFeasibilityAnalysis` in all aspects but name, so we are naming the former `ConstraintsFeasibilityAnalysis` and deleting the latter

Differential Revision: D86808454
…easibilityAnalysis` (facebook#4527)

Summary:

As titled, we believe `IndividualConstraintsFeasibilityAnalysis` is strictly better than `ConstraintsFeasibilityAnalysis` in all aspects but name, so we are naming the former `ConstraintsFeasibilityAnalysis` and deleting the latter

Differential Revision: D86808454
@meta-codesync
Copy link

meta-codesync bot commented Nov 25, 2025

This pull request has been merged in dbece4f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants