Skip to content

Conversation

@jandylin
Copy link

Summary:
Switch default MBM acquisition function for MOO from qLogNoisyExpectedHypervolumeImprovement to qLogNParEgo if number of objectives > 4.

Counting of objectives in this change relies on torch_opt_config.objective_weights.count_nonzero() which could potentially break for scalarized MOO (although the latter is currently not supported).

Differential Revision: D83160003

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 24, 2025
@facebook-github-bot
Copy link
Contributor

@jandylin has exported this pull request. If you are a Meta employee, you can view the originating diff in D83160003.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.27%. Comparing base (7147431) to head (35c50ad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4347      +/-   ##
==========================================
- Coverage   96.28%   96.27%   -0.01%     
==========================================
  Files         566      566              
  Lines       58165    58170       +5     
==========================================
+ Hits        56004    56006       +2     
- Misses       2161     2164       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Summary:

Switch default MBM acquisition function for MOO from `qLogNoisyExpectedHypervolumeImprovement` to `qLogNParEgo` if number of objectives > 4.

Counting of objectives in this change relies on `torch_opt_config.objective_weights.count_nonzero()` which could potentially break for scalarized MOO (although the latter is currently not supported).

Differential Revision: D83160003
@facebook-github-bot
Copy link
Contributor

@jandylin has exported this pull request. If you are a Meta employee, you can view the originating diff in D83160003.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1b5eec9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants