handle scalarized constraints in ResultsAnalysis #4193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80653847 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4193 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 561 561
Lines 56957 57009 +52
=======================================
+ Hits 54765 54815 +50
- Misses 2192 2194 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nts (facebook#4181) Summary: Pull Request resolved: facebook#4181 `MultiObjectiveOptimizationConfig` constraint validation will err when trying to extract metric names from `ScalarizedOutcomeConstraint`. This change fixes it. Meta: this blocks the loading of some experiments. Reviewed By: Balandat Differential Revision: D80640567
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
Aug 22, 2025
Summary: `ResultsAnalysis` will err when trying to extract metric names from `ScalarizedOutcomeConstraint`. This change fixes it. Meta: Currently we treat the mean/sem of the scalarized outcome constraint as nan (hence the feasibility of it) and avoid the error. Created T235432214 explicitly calculate the scalarized constraint values when calculating feasibility. Reviewed By: Balandat Differential Revision: D80653847
ItsMrLin
force-pushed
the
export-D80653847
branch
from
ee2047f to
25b881d
Compare
Summary: Pull Request resolved: facebook#4193 `ResultsAnalysis` will err when trying to extract metric names from `ScalarizedOutcomeConstraint`. This change fixes it. Meta: Currently we treat the mean/sem of the scalarized outcome constraint as nan (hence the feasibility of it) and avoid the error. Created T235432214 explicitly calculate the scalarized constraint values when calculating feasibility. Reviewed By: Balandat Differential Revision: D80653847
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80653847 |
ItsMrLin
force-pushed
the
export-D80653847
branch
from
25b881d to
2f64de5
Compare
Contributor
|
This pull request has been merged in 0542753. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ResultsAnalysiswill err when trying to extract metric names fromScalarizedOutcomeConstraint. This change fixes it.Meta: Currently we treat the mean/sem of the scalarized outcome constraint as nan (hence the feasibility of it) and avoid the error. Created T235432214 explicitly calculate the scalarized constraint values when calculating feasibility.
Reviewed By: Balandat
Differential Revision: D80653847