Allow only float map keys #4164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: **Context**: Map values must satisfy two properties: * They need to be ordered such that it makes sense to take the largest value and modeled that or to sort on those values. * They shouldn't be typed as ints, since as we learned in D79938692 / Ax facebook#4126, this can result in floats getting cast to ints later. * They shouldn't be weird since they need to be serializable. This leaves one obvious candidate: float. Fortunately, existing usages seem to be floats. **This PR**: * Makes all map keys floats * Removes some type annotation logic that is now extraneous * Renames a silly test class (I had used "TestMapDataXYZ" to make it easier to run several related groups of tests via CLI then forgot to change it back.) Differential Revision: D80473359
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80473359 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4164 +/- ##
=======================================
Coverage 96.05% 96.06%
=======================================
Files 566 566
Lines 57217 57216 -1
=======================================
Hits 54962 54962
+ Misses 2255 2254 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This pull request has been merged in b2adff9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
Map values must satisfy two properties:
This leaves one obvious candidate: float. Fortunately, existing usages seem to be floats.
This PR:
Differential Revision: D80473359