MBM: Do not error out if infer_objective_thresholds fails #4149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `convert_to_block_design` is used for two purposes: - In model fitting, to merge the datasets if a batched model is **allowed**. If something errors out here, we should just use a model-list rather than erroring out model fitting. We should also not use `force=True` here, since it is generally favorable to keep all the training data rather than forcing it to be block design by dropping some observations. - In acquisition function selection, to see if any feasible points have been observed. We use `force=True` here, since we really need block design observations to evaluate feasibility. But we don't care about noise observations, so we shouldn't error out if only a subset of the datasets have noise. We can simply drop the noise. Differential Revision: D80205523 Reviewed By: sunnyshen321
Summary: `Acquisition._update_objective_thresholds` or `infer_objective_thresholds` call within can lead to errors during `Acquisition` initialization, even if the corresponding acquisition function doesn't need objective thresholds. We have some conditional logic to protect against this but it is not comprehensive enough. The particular example that triggered this diff is the use of P_Feasible acquisition function when there are no feasible points. In this case, we can't infer objective thresholds since we need feasible points. This diff adds a `try/except` block to catch errors raised in `infer_objective_thresholds` and logs a warning if any error is caught. This should make it possible to easily debug any related errors (thanks to the log) while letting the acquisition functions that don't need the thresholds run without issues. Differential Revision: D80259199
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80259199 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4149 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 566 566
Lines 57157 57189 +32
=======================================
+ Hits 54897 54930 +33
+ Misses 2260 2259 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Aug 14, 2025
) Summary: `Acquisition._update_objective_thresholds` or `infer_objective_thresholds` call within can lead to errors during `Acquisition` initialization, even if the corresponding acquisition function doesn't need objective thresholds. We have some conditional logic to protect against this but it is not comprehensive enough. The particular example that triggered this diff is the use of P_Feasible acquisition function when there are no feasible points. In this case, we can't infer objective thresholds since we need feasible points. This diff adds a `try/except` block to catch errors raised in `infer_objective_thresholds` and logs a warning if any error is caught. This should make it possible to easily debug any related errors (thanks to the log) while letting the acquisition functions that don't need the thresholds run without issues. Reviewed By: sunnyshen321 Differential Revision: D80259199
Contributor
|
This pull request has been merged in ef7081a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Acquisition._update_objective_thresholdsorinfer_objective_thresholdscall within can lead to errors duringAcquisitioninitialization, even if the corresponding acquisition function doesn't need objective thresholds. We have some conditional logic to protect against this but it is not comprehensive enough.The particular example that triggered this diff is the use of P_Feasible acquisition function when there are no feasible points. In this case, we can't infer objective thresholds since we need feasible points.
This diff adds a
try/exceptblock to catch errors raised ininfer_objective_thresholdsand logs a warning if any error is caught. This should make it possible to easily debug any related errors (thanks to the log) while letting the acquisition functions that don't need the thresholds run without issues.Differential Revision: D80259199