clone_reset support for DeterministicGenerationNode #4134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80093006 |
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 12, 2025
Summary: clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues unittesting benchmarking functionality, such as benchmark_replication. Differential Revision: D80093006
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 566 567 +1
Lines 57129 57159 +30
=======================================
+ Hits 54869 54899 +30
Misses 2260 2260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 12, 2025
Summary: clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues unittesting benchmarking functionality, such as benchmark_replication. Differential Revision: D80093006
|
This pull request was exported from Phabricator. Differential Revision: D80093006 |
hvarfner
force-pushed
the
export-D80093006
branch
from
7f60edb to
79de332
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#4134 clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
|
This pull request was exported from Phabricator. Differential Revision: D80093006 |
hvarfner
force-pushed
the
export-D80093006
branch
from
79de332 to
9abe435
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#4134 clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
|
This pull request was exported from Phabricator. Differential Revision: D80093006 |
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#4134 clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
hvarfner
force-pushed
the
export-D80093006
branch
from
9abe435 to
307b591
Compare
Summary: Pull Request resolved: facebook#4137 Differential Revision: D80117995
Summary: Pull Request resolved: facebook#4134 clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
|
This pull request was exported from Phabricator. Differential Revision: D80093006 |
hvarfner
force-pushed
the
export-D80093006
branch
from
307b591 to
aef0a4f
Compare
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 13, 2025
Summary: clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 13, 2025
Summary: clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 14, 2025
Summary: clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 14, 2025
Summary: clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 15, 2025
Summary: clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
hvarfner
pushed a commit
to hvarfner/Ax
that referenced
this pull request
Aug 15, 2025
Summary: clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy. This causes issues when unittesting benchmarking functionality, such as benchmark_replication. Currently, run orchestrator benchmarking tests on a clone of an unused GS, which keeps the issue in this diff from getting exposed. However, This means that we don't have access to the GS's state when computing `BenchmarkResult`s - an issue that is addressed in the subsequent diff. Differential Revision: D80093006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
clone_reset currently does not work for DeterministicGenerationNode, as the iterator is not reset when the method is called on the generation strategy.
This causes issues unittesting benchmarking functionality, such as benchmark_replication.
Rollback Plan:
Differential Revision: D80093006