Group CVs as AnalysisCardGroup in DiagnosticAnalysis #4112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79558715 |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 6, 2025
Summary: This diff groups the cross-validation plots in the `DiagnosticAnalysis` class of Ax. The code changes in the `diagnostics.py` file include the creation of a new `AnalysisCardGroup` for cross-validation plots. The `CrossValidationPlot` class is also modified to include a new `CV_CARDGROUP_SUBTITLE` and `CV_CARDGROUP_TITLE` attribute. Reviewed By: mpolson64 Differential Revision: D79558715
shrutipatel31
force-pushed
the
export-D79558715
branch
from
5d693cb to
a22f2fe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79558715 |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 6, 2025
Summary: Pull Request resolved: facebook#4112 This diff groups the cross-validation plots in the `DiagnosticAnalysis` class of Ax. The code changes in the `diagnostics.py` file include the creation of a new `AnalysisCardGroup` for cross-validation plots. The `CrossValidationPlot` class is also modified to include a new `CV_CARDGROUP_SUBTITLE` and `CV_CARDGROUP_TITLE` attribute. Reviewed By: mpolson64 Differential Revision: D79558715
shrutipatel31
force-pushed
the
export-D79558715
branch
from
a22f2fe to
fac094a
Compare
Summary: This diff groups the cross-validation plots in the `DiagnosticAnalysis` class of Ax. The code changes in the `diagnostics.py` file include the creation of a new `AnalysisCardGroup` for cross-validation plots. The `CrossValidationPlot` class is also modified to include a new `CV_CARDGROUP_SUBTITLE` and `CV_CARDGROUP_TITLE` attribute. Reviewed By: mpolson64 Differential Revision: D79558715
shrutipatel31
force-pushed
the
export-D79558715
branch
from
fac094a to
a510ae5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79558715 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4112 +/- ##
==========================================
- Coverage 96.07% 96.07% -0.01%
==========================================
Files 566 566
Lines 57043 57043
==========================================
- Hits 54806 54805 -1
- Misses 2237 2238 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This pull request has been merged in da8b59c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff groups the cross-validation plots in the
DiagnosticAnalysisclass of Ax. The code changes in thediagnostics.pyfile include the creation of a newAnalysisCardGroupfor cross-validation plots. TheCrossValidationPlotclass is also modified to include a newCV_CARDGROUP_SUBTITLEandCV_CARDGROUP_TITLEattribute.Reviewed By: mpolson64
Differential Revision: D79558715