Skip to content

Deprecate GPBased ESS classes #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saitcakmak
Copy link
Contributor

Summary: Deprecates ModelBasedEarlyStoppingStrategy.get_training_data and other ESS implementations that relied on this method.

Reviewed By: ltiao

Differential Revision: D77743915

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 15, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77743915

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.03%. Comparing base (522dbe6) to head (ea781ee).

Files with missing lines Patch % Lines
ax/early_stopping/strategies/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4037      +/-   ##
==========================================
- Coverage   96.04%   96.03%   -0.01%     
==========================================
  Files         564      564              
  Lines       56271    56229      -42     
==========================================
- Hits        54043    54001      -42     
  Misses       2228     2228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Summary:

Deprecates `ModelBasedEarlyStoppingStrategy.get_training_data` and other ESS implementations that relied on this method.

Reviewed By: ltiao

Differential Revision: D77743915
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77743915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants