Use OverviewAnalysis (instead of _choose_analyses) in Client #4013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77873154 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
==========================================
- Coverage 95.99% 95.96% -0.03%
==========================================
Files 562 562
Lines 56293 56309 +16
==========================================
+ Hits 54036 54039 +3
- Misses 2257 2270 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: Post AnalysisCardGroup refactor these classes no longer hold any meaning and can just be replaced by Analysis. Note that PlotlyAnalysisCard, MarkdownAnalysisCard, etc are still of course necessary and still remain Differential Revision: D77896085
Summary: Add new title, subtitle fields to AnalysisCardBase so that both AnalysisCard and AnalysisCard groups can have subtitles and titles. This will help provide the user with more useful information at rendering time. This means AnalysisCardBase has three pieces of data (plus timestamp): * `name` should note the name of the Analysis which produced the group. Not human readable, just useful for grouping and filtering from within python. In general this should not hold any information about the actual data in the card or card group, just what "kind" of card it is (ex. ContourPlot, ArmEffectsPair, etc) * `title` is intended for humans to read and will appear at the top of the card. This can refer to the actual data presented by the card. (ex. x1 vs. Hartmann6, Predicted and Observed Effects on QPS, etc) * `subtitle` is intended for humans to read (either underneath the title or as a tooltip) and should contain a sentence or two necessary for a novice user to interpret the plot (ex. "The parallel coordinates plot is a common method of visualizing high-dimensional datasets. Each line represents a single arm in the experiment: the location at which it intersects each parallel line indicates which point in the search space was evaluated by that arm, and the rightmost parallel line shows the metric value. Clusters of lines close together indicate the experiment is converging on promising regions of the search space, while a plot without clustering indicates no such convergence.") All titles and subtitles currently have placeholder values of T230247379 -- these need to be addressed cc eonofrey Differential Revision: D77897653
Summary: wip Differential Revision: D77935791
…k#4013) Summary: Pull Request resolved: facebook#4013 As titled Reviewed By: mgarrard Differential Revision: D77873154
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77873154 |
mpolson64
force-pushed
the
export-D77873154
branch
from
1e91678 to
e64a561
Compare
Contributor
|
This pull request has been merged in 5f4fbd2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As titled
Differential Revision: D77873154