Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ax/generators/torch/botorch_modular/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@
)
from botorch.fit import fit_fully_bayesian_model_nuts, fit_gpytorch_mll
from botorch.models import PairwiseLaplaceMarginalLogLikelihood
from botorch.models.fully_bayesian import FullyBayesianSingleTaskGP
from botorch.models.fully_bayesian import (
AbstractFullyBayesianSingleTaskGP,
FullyBayesianSingleTaskGP,
)
from botorch.models.fully_bayesian_multitask import SaasFullyBayesianMultiTaskGP
from botorch.models.gp_regression import SingleTaskGP
from botorch.models.gp_regression_fidelity import SingleTaskMultiFidelityGP
Expand Down Expand Up @@ -532,10 +535,11 @@ def _fit_botorch_model_gpytorch(
fit_gpytorch_mll(mll)


@fit_botorch_model.register(FullyBayesianSingleTaskGP)
@fit_botorch_model.register(SaasFullyBayesianMultiTaskGP)
@fit_botorch_model.register(
(AbstractFullyBayesianSingleTaskGP, SaasFullyBayesianMultiTaskGP)
)
def _fit_botorch_model_fully_bayesian_nuts(
model: FullyBayesianSingleTaskGP | SaasFullyBayesianMultiTaskGP,
model: AbstractFullyBayesianSingleTaskGP | SaasFullyBayesianMultiTaskGP,
mll_class: type[MarginalLogLikelihood],
mll_options: dict[str, Any] | None = None,
) -> None:
Expand Down
5 changes: 4 additions & 1 deletion ax/generators/torch/tests/test_surrogate.py
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,10 @@ def test_construct_model(self) -> None:
self.assertTrue(torch.equal(call_kwargs["train_Y"], self.Ys[0]))
self.assertIsInstance(call_kwargs["input_transform"], Normalize)
self.assertIsNone(call_kwargs["outcome_transform"])
self.assertEqual(len(call_kwargs), 4)
self.assertEqual(
len(call_kwargs),
6 if botorch_model_class is SaasFullyBayesianSingleTaskGP else 4,
)

mock_construct_inputs.assert_called_with(
training_data=self.training_data[0],
Expand Down
8 changes: 6 additions & 2 deletions ax/storage/botorch_modular_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,12 @@
AnalyticExpectedUtilityOfBestOption,
qExpectedUtilityOfBestOption,
)
from botorch.models import SaasFullyBayesianSingleTaskGP
from botorch.models.contextual import LCEAGP
from botorch.models.fully_bayesian import FullyBayesianLinearSingleTaskGP
from botorch.models.fully_bayesian import (
FullyBayesianLinearSingleTaskGP,
FullyBayesianSingleTaskGP,
SaasFullyBayesianSingleTaskGP,
)
from botorch.models.fully_bayesian_multitask import SaasFullyBayesianMultiTaskGP

# BoTorch `Model` imports
Expand Down Expand Up @@ -124,6 +127,7 @@
SingleTaskMultiFidelityGP: "SingleTaskMultiFidelityGP",
FullyBayesianLinearSingleTaskGP: "FullyBayesianLinearSingleTaskGP",
SaasFullyBayesianSingleTaskGP: "SaasFullyBayesianSingleTaskGP",
FullyBayesianSingleTaskGP: "FullyBayesianSingleTaskGP",
SaasFullyBayesianMultiTaskGP: "SaasFullyBayesianMultiTaskGP",
LCEAGP: "LCEAGP",
}
Expand Down
Loading