Mock out ax_parameter_sens in online/offline tests #3648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Should be safe since ax_parameter_sens is tested elsewhere. These tests try and call compute() using over 100 different experiments, making each test very expensive -- this doubled our OSS unit testing time. With these changes the tests go from taking ~300s to ~50s on my machine in dev mode. Differential Revision: D73066856
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73066856 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 550 550
Lines 54368 54371 +3
=======================================
+ Hits 52241 52244 +3
Misses 2127 2127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Should be safe since ax_parameter_sens is tested elsewhere.
These tests try and call compute() using over 100 different experiments, making each test very expensive -- this doubled our OSS unit testing time. With these changes the tests go from taking ~300s to ~50s on my machine in dev mode.
Differential Revision: D73066856