Update the remaining models to use new default covar & likelihood modules #2742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62196414 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 5, 2024
…ules (meta-pytorch#2507) Summary: X-link: facebook/Ax#2742 Pull Request resolved: meta-pytorch#2507 Updates the default covar & likelihood modules of BoTorch models. See meta-pytorch#2451 for details on the new defaults. For models that utilize a composite kernel, such as multi-fidelity/task/context, this change only affects the base kernel. Exceptions / Models that do not utilize the new modules: - Fully-bayesian models. - Pairwise GP. - Higher order GP: Produced weird division by zero errors after the change. - Fidelity kernels for MF models. - (likelihood only) Any model that utilizes a likelihood other than `GaussianLikelihood` (e.g., `MultiTaskGaussianLikelihood`). Reviewed By: esantorella Differential Revision: D62196414
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62196414 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Sep 5, 2024
…ules (facebook#2742) Summary: Pull Request resolved: facebook#2742 X-link: meta-pytorch/botorch#2507 Updates the default covar & likelihood modules of BoTorch models. See meta-pytorch/botorch#2451 for details on the new defaults. For models that utilize a composite kernel, such as multi-fidelity/task/context, this change only affects the base kernel. Exceptions / Models that do not utilize the new modules: - Fully-bayesian models. - Pairwise GP. - Higher order GP: Produced weird division by zero errors after the change. - Fidelity kernels for MF models. - (likelihood only) Any model that utilizes a likelihood other than `GaussianLikelihood` (e.g., `MultiTaskGaussianLikelihood`). Reviewed By: esantorella Differential Revision: D62196414
saitcakmak
force-pushed
the
export-D62196414
branch
from
5b8f61c to
41b9e67
Compare
…ules (facebook#2742) Summary: Pull Request resolved: facebook#2742 X-link: meta-pytorch/botorch#2507 Updates the default covar & likelihood modules of BoTorch models. See meta-pytorch/botorch#2451 for details on the new defaults. For models that utilize a composite kernel, such as multi-fidelity/task/context, this change only affects the base kernel. Exceptions / Models that do not utilize the new modules: - Fully-bayesian models. - Pairwise GP. - Higher order GP: Produced weird division by zero errors after the change. - Fidelity kernels for MF models. - (likelihood only) Any model that utilizes a likelihood other than `GaussianLikelihood` (e.g., `MultiTaskGaussianLikelihood`). Reviewed By: esantorella Differential Revision: D62196414
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62196414 |
saitcakmak
force-pushed
the
export-D62196414
branch
from
41b9e67 to
7899d5b
Compare
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Sep 5, 2024
…ules (meta-pytorch#2507) Summary: X-link: facebook/Ax#2742 Pull Request resolved: meta-pytorch#2507 Updates the default covar & likelihood modules of BoTorch models. See meta-pytorch#2451 for details on the new defaults. For models that utilize a composite kernel, such as multi-fidelity/task/context, this change only affects the base kernel. Exceptions / Models that do not utilize the new modules: - Fully-bayesian models. - Pairwise GP. - Higher order GP: Produced weird division by zero errors after the change. - Fidelity kernels for MF models. - (likelihood only) Any model that utilizes a likelihood other than `GaussianLikelihood` (e.g., `MultiTaskGaussianLikelihood`). Reviewed By: esantorella Differential Revision: D62196414
Contributor
|
This pull request has been merged in 81a4e5b. |
facebook-github-bot
pushed a commit
to meta-pytorch/botorch
that referenced
this pull request
Sep 5, 2024
…ules (#2507) Summary: X-link: facebook/Ax#2742 Pull Request resolved: #2507 Updates the default covar & likelihood modules of BoTorch models. See #2451 for details on the new defaults. For models that utilize a composite kernel, such as multi-fidelity/task/context, this change only affects the base kernel. Exceptions / Models that do not utilize the new modules: - Fully-bayesian models. - Pairwise GP. - Higher order GP: Produced weird division by zero errors after the change. - Fidelity kernels for MF models. - (likelihood only) Any model that utilizes a likelihood other than `GaussianLikelihood` (e.g., `MultiTaskGaussianLikelihood`). Reviewed By: esantorella Differential Revision: D62196414 fbshipit-source-id: e2c8983a49a9f00d878e1fb7cf346212acb895e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta-pytorch/botorch#2507
Updates the default covar & likelihood modules of BoTorch models. See meta-pytorch/botorch#2451 for details on the new defaults.
For models that utilize a composite kernel, such as multi-fidelity/task/context, this change only affects the base kernel.
Exceptions / Models that do not utilize the new modules:
GaussianLikelihood(e.g.,MultiTaskGaussianLikelihood).Reviewed By: esantorella
Differential Revision: D62196414