Update test_generation_strategy to utilize MBM models #2734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `Models.GPEI` points to the deprecated legacy Ax model. For most practical usage, it behaves identical to `Models.BOTORCH_MODULAR` (aka MBM), which is the recommmended model to use in Ax. This diff updates many use cases to make it easier to fully deprecate the registry entry down the line. Differential Revision: D62146528
Summary: Models.GPEI points to the deprecated legacy Ax model. For most practical usage, it behaves identical to Models.BOTORCH_MODULAR (aka MBM), which is the recommmended model to use in Ax. This diff updates `test_generation_strategy` file to utilize MBM instead of legacy GPEI. Differential Revision: D62164294
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D62164294 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2734 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 489 489
Lines 47861 47859 -2
=======================================
- Hits 45694 45693 -1
+ Misses 2167 2166 -1 ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request has been merged in 6b1b0a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Models.GPEI points to the deprecated legacy Ax model. For most practical usage, it behaves identical to Models.BOTORCH_MODULAR (aka MBM), which is the recommmended model to use in Ax. This diff updates
test_generation_strategyfile to utilize MBM instead of legacy GPEI.Differential Revision: D62164294