Add an option to override ModelSpec.model_key #2726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61984169 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
=======================================
Coverage 95.41% 95.42%
=======================================
Files 490 490
Lines 47862 47872 +10
=======================================
+ Hits 45669 45681 +12
+ Misses 2193 2191 -2 ☔ View full report in Codecov by Sentry. |
Summary: Pull Request resolved: facebook#2726 Most of our models now utilize MBM, which can represent many different models using the same Models.BOTORCH_MODULAR. Being able to overwrite the default model key "BoTorch" will allow us to be more expressive about what model was used to generate a given candidate. Follow-up diff will utilize this to require unique model key for each ModelSpec in a GenerationNode, which will ensure identifiability when multiple MBM models are used with model selection. Differential Revision: D61984169
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61984169 |
saitcakmak
force-pushed
the
export-D61984169
branch
from
ca3ee3e to
4f44c89
Compare
Contributor
|
This pull request has been merged in 1f6661a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Most of our models now utilize MBM, which can represent many different models using the same Models.BOTORCH_MODULAR. Being able to overwrite the default model key "BoTorch" will allow us to be more expressive about what model was used to generate a given candidate.
Follow-up diff will utilize this to require unique model key for each ModelSpec in a GenerationNode, which will ensure identifiability when multiple MBM models are used with model selection.
Differential Revision: D61984169