Add evaluate_oracle method to BenchmarkRunner
#2705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61431980 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2705 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 493 493
Lines 47899 47903 +4
=======================================
+ Hits 45639 45643 +4
Misses 2260 2260 ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61431980 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebook#2705 Docstring should make this self-explanatory. In addition to the increased ease of development, enables reaping a lot of LOC in D61415525 Reviewed By: Balandat Differential Revision: D61431980
esantorella
force-pushed
the
export-D61431980
branch
from
3cd6546 to
81cc983
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebook#2705 Docstring should make this self-explanatory. In addition to the increased ease of development, enables reaping a lot of LOC in D61415525 Reviewed By: Balandat Differential Revision: D61431980
esantorella
force-pushed
the
export-D61431980
branch
from
81cc983 to
ea82e45
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61431980 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61431980 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 24, 2024
Summary: Pull Request resolved: facebook#2705 Docstring should make this self-explanatory. In addition to the increased ease of development, enables reaping a lot of LOC in D61415525 Reviewed By: Balandat Differential Revision: D61431980
esantorella
force-pushed
the
export-D61431980
branch
from
ea82e45 to
a244d6a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61431980 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 25, 2024
Summary: Pull Request resolved: facebook#2705 Docstring should make this self-explanatory. In addition to the increased ease of development, enables reaping a lot of LOC in D61415525 Reviewed By: Balandat Differential Revision: D61431980
esantorella
force-pushed
the
export-D61431980
branch
from
a244d6a to
df42735
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61431980 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 25, 2024
Summary: Pull Request resolved: facebook#2705 Docstring should make this self-explanatory. In addition to the increased ease of development, enables reaping a lot of LOC in D61415525 Reviewed By: Balandat Differential Revision: D61431980
esantorella
force-pushed
the
export-D61431980
branch
from
df42735 to
b031fd1
Compare
Summary: Pull Request resolved: facebook#2705 Docstring should make this self-explanatory. In addition to the increased ease of development, enables reaping a lot of LOC in D61415525 Reviewed By: Balandat Differential Revision: D61431980
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61431980 |
esantorella
force-pushed
the
export-D61431980
branch
from
b031fd1 to
e0841db
Compare
Contributor
|
This pull request has been merged in 36194d3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Docstring should make this self-explanatory.
In addition to the increased ease of development, enables reaping a lot of LOC in D61415525
Reviewed By: Balandat
Differential Revision: D61431980