Implement Data/MapData.clone and use it in Experiment.clone_with #2703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61715842 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2703 +/- ##
=======================================
Coverage 95.39% 95.40%
=======================================
Files 492 492
Lines 47920 47956 +36
=======================================
+ Hits 45715 45751 +36
Misses 2205 2205 ☔ View full report in Codecov by Sentry. |
…ebook#2703) Summary: Pull Request resolved: facebook#2703 Prior to this change, the data attached to the cloned experiment would retain the `_db_id` of the original. When the clone experiment is saved, this would lead to overwriting the DB entry to point to the clone experiment, effectively deleting the data attached to the original experiment. This diff implements `clone` methods for `Data` and `MapData`, and uses it in `Experiment.clone_with` to avoid this issue. Differential Revision: D61715842
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61715842 |
saitcakmak
force-pushed
the
export-D61715842
branch
from
05f4e75 to
ccff23f
Compare
Contributor
|
This pull request has been merged in dc0fba0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Prior to this change, the data attached to the cloned experiment would retain the
_db_idof the original. When the clone experiment is saved, this would lead to overwriting the DB entry to point to the clone experiment, effectively deleting the data attached to the original experiment.This diff implements
clonemethods forDataandMapData, and uses it inExperiment.clone_withto avoid this issue.Differential Revision: D61715842