Change time limit for unit tests to 60 seconds and introduce a decorator for long running tests #2661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61212556 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61212556 |
paschai
added a commit
to paschai/Ax
that referenced
this pull request
Aug 15, 2024
…tor for long running tests (facebook#2661) Summary: Pull Request resolved: facebook#2661 This diff is to change the time limit for unit tests to 60 seconds and introduce a decorator for long running tests. We'll use the `ax_long_text` decorator to identify all long running tests, which we can fix over time by creating backlog tasks for test-owners to update these long-running tests with a descriptive message. This change also introduces this decorator to all tests running over 60 seconds. For now, the provided reason for these long running tests are placeholders. Differential Revision: D61212556
paschai
force-pushed
the
export-D61212556
branch
from
0ee0c37 to
0dc59ec
Compare
…tor for long running tests (facebook#2661) Summary: Pull Request resolved: facebook#2661 This diff is to change the time limit for unit tests to 60 seconds and introduce a decorator for long running tests. We'll use the `ax_long_text` decorator to identify all long running tests, which we can fix over time by creating backlog tasks for test-owners to update these long-running tests with a descriptive message. This change also introduces this decorator to all tests running over 60 seconds. For now, the provided reason for these long running tests are placeholders. Reviewed By: mpolson64 Differential Revision: D61212556
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61212556 |
paschai
force-pushed
the
export-D61212556
branch
from
0dc59ec to
e1e5a13
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
==========================================
- Coverage 95.29% 95.28% -0.01%
==========================================
Files 492 492
Lines 47815 47834 +19
==========================================
+ Hits 45566 45581 +15
- Misses 2249 2253 +4 ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request has been merged in c8da4ba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is to change the time limit for unit tests to 60 seconds and introduce a decorator for long running tests.
We'll use the
ax_long_textdecorator to identify all long running tests, which we can fix over time by creating backlog tasks for test-owners to update these long-running tests with a descriptive message.This change also introduces this decorator to all tests running over 60 seconds. For now, the provided reason for these long running tests are placeholders.
Differential Revision: D61212556