Add Scheduler.compute_analyses method #2660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61338432 |
Summary: Pull Request resolved: facebook#2660 Adds a method for bulk computing Analyses from a Scheduler instance and save the cards to the DB. This can be used to generate a "report" as needed. Notes: * If any Analysis fails to compute and Error is logged, but compute_analyses otherwise succeeds. Down the line we may wish to accumulate the errors into their own ErrorCard * If not Analyses are provided to compute_analyses, _choose_analyses will be called to infer which analyses should be computed for the given Scheduler based on the Experiment, GenerationStrategy, etc. Since only ParallelCoordinates is implemented right now this always returns [ParallelCoordinates()] Reviewed By: Cesar-Cardoso Differential Revision: D61338432
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61338432 |
mpolson64
force-pushed
the
export-D61338432
branch
from
4d9ef22 to
3586497
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2660 +/- ##
==========================================
+ Coverage 95.28% 95.29% +0.01%
==========================================
Files 495 495
Lines 47800 47832 +32
==========================================
+ Hits 45545 45582 +37
+ Misses 2255 2250 -5 ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request has been merged in 84b307d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a method for bulk computing Analyses from a Scheduler instance and save the cards to the DB. This can be used to generate a "report" as needed.
Notes:
Differential Revision: D61338432