Pass botorch_model_class to Surrogate._set_formatted_inputs
#2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61212316 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2653 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 493 493
Lines 47746 47746
=======================================
Hits 45497 45497
Misses 2249 2249 ☔ View full report in Codecov by Sentry. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61212316 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 13, 2024
…book#2653) Summary: Pull Request resolved: facebook#2653 Context: `Surrogate._set_formatted_inputs` is used only in the following context: - A model input constructor sets inputs on the basis of a `botorch_model_class` and a `surrogate`. It checks which inputs are valid based on the `botorch_model_class` - The input constructor calls `_set_formatted_inputs`; if the inputs are not valid (as per the above bullet), it raises an exception. - However, `_set_formatted_inputs` uses `surrogate.botorch_model_class` rather than `botorch_model_class`, which may not be the same, and can raise a nonsensical error. Hence there was a unit test raising a puzzling exception that SaasFullyBayesianSingleTaskGP does not support `outcome_transform` (it does), when it should have been saying that `SingleTaskGPWithDifferentConstructor`, the model in question, doesn't support `outcome_transform`. This PR: - Passes `botorch_model_class` to `_set_formatted_inputs` - changes some `list` annotations to `Sequence` to fix type errors Reviewed By: Balandat Differential Revision: D61212316
esantorella
force-pushed
the
export-D61212316
branch
from
9de5a1a to
bbbb9a8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61212316 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 13, 2024
…book#2653) Summary: Pull Request resolved: facebook#2653 Context: `Surrogate._set_formatted_inputs` is used only in the following context: - A model input constructor sets inputs on the basis of a `botorch_model_class` and a `surrogate`. It checks which inputs are valid based on the `botorch_model_class` - The input constructor calls `_set_formatted_inputs`; if the inputs are not valid (as per the above bullet), it raises an exception. - However, `_set_formatted_inputs` uses `surrogate.botorch_model_class` rather than `botorch_model_class`, which may not be the same, and can raise a nonsensical error. Hence there was a unit test raising a puzzling exception that SaasFullyBayesianSingleTaskGP does not support `outcome_transform` (it does), when it should have been saying that `SingleTaskGPWithDifferentConstructor`, the model in question, doesn't support `outcome_transform`. This PR: - Passes `botorch_model_class` to `_set_formatted_inputs` - changes some `list` annotations to `Sequence` to fix type errors Reviewed By: Balandat Differential Revision: D61212316
esantorella
force-pushed
the
export-D61212316
branch
from
bbbb9a8 to
acfa301
Compare
…book#2653) Summary: Pull Request resolved: facebook#2653 Context: `Surrogate._set_formatted_inputs` is used only in the following context: - A model input constructor sets inputs on the basis of a `botorch_model_class` and a `surrogate`. It checks which inputs are valid based on the `botorch_model_class` - The input constructor calls `_set_formatted_inputs`; if the inputs are not valid (as per the above bullet), it raises an exception. - However, `_set_formatted_inputs` uses `surrogate.botorch_model_class` rather than `botorch_model_class`, which may not be the same, and can raise a nonsensical error. Hence there was a unit test raising a puzzling exception that SaasFullyBayesianSingleTaskGP does not support `outcome_transform` (it does), when it should have been saying that `SingleTaskGPWithDifferentConstructor`, the model in question, doesn't support `outcome_transform`. This PR: - Passes `botorch_model_class` to `_set_formatted_inputs` - changes some `list` annotations to `Sequence` to fix type errors Reviewed By: Balandat Differential Revision: D61212316
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61212316 |
esantorella
force-pushed
the
export-D61212316
branch
from
acfa301 to
df186c5
Compare
Contributor
|
This pull request has been merged in 310b43d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
Surrogate._set_formatted_inputsis used only in the following context:botorch_model_classand asurrogate. It checks which inputs are valid based on thebotorch_model_class_set_formatted_inputs; if the inputs are not valid (as per the above bullet), it raises an exception._set_formatted_inputsusessurrogate.botorch_model_classrather thanbotorch_model_class, which may not be the same, and can raise a nonsensical error. Hence there was a unit test raising a puzzling exception that SaasFullyBayesianSingleTaskGP does not supportoutcome_transform(it does), when it should have been saying thatSingleTaskGPWithDifferentConstructor, the model in question, doesn't supportoutcome_transform.This PR:
botorch_model_classto_set_formatted_inputslistannotations toSequenceto fix type errorsDifferential Revision: D61212316