Fix Surrogate.best_out_of_sample_point
#2652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61209456 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61209456 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#2652 Context: This was erroring because it was trying to index into a 0d tensor. This issue wasn't caught because the unit test mocked out underlying BoTorch functionality. `optimize_acqf` returns a 0d tensor when q=1 and `return_best` is True (the default). This PR: - Adds a docstring - Replaces `acqf_values[0]` with `acqf_values`. Differential Revision: D61209456
esantorella
force-pushed
the
export-D61209456
branch
from
18a0cf2 to
6dfd9fe
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61209456 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#2652 Context: This was erroring because it was trying to index into a 0d tensor. This issue wasn't caught because the unit test mocked out underlying BoTorch functionality. `optimize_acqf` returns a 0d tensor when q=1 and `return_best` is True (the default). This PR: - Adds a docstring - Replaces `acqf_values[0]` with `acqf_values`. Differential Revision: D61209456
esantorella
force-pushed
the
export-D61209456
branch
from
6dfd9fe to
9877287
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2652 +/- ##
==========================================
- Coverage 95.28% 95.26% -0.03%
==========================================
Files 493 493
Lines 47746 47753 +7
==========================================
- Hits 45497 45493 -4
- Misses 2249 2260 +11 ☔ View full report in Codecov by Sentry. |
1 task
Summary: Context: `Surrogate._set_formatted_inputs` is used only in the following context: - A model input constructor sets inputs on the basis of a `botorch_model_class` and a `surrogate`. It checks which inputs are valid based on the `botorch_model_class` - The input constructor calls `_set_formatted_inputs`; if the inputs are not valid (as per the above bullet), it raises an exception. - However, `_set_formatted_inputs` uses `surrogate.botorch_model_class` rather than `botorch_model_class`, which may not be the same, and can raise a nonsensical error. Hence there was a unit test raising a puzzling exception that SaasFullyBayesianSingleTaskGP does not support `outcome_transform` (it does), when it should have been saying that `SingleTaskGPWithDifferentConstructor`, the model in question, doesn't support `outcome_transform`. This PR: - Passes `botorch_model_class` to `_set_formatted_inputs` - changes some `list` annotations to `Sequence` to fix type errors Differential Revision: D61212316
Summary: Pull Request resolved: facebook#2652 Context: This was erroring because it was trying to index into a 0d tensor. This issue wasn't caught because the unit test mocked out underlying BoTorch functionality. `optimize_acqf` returns a 0d tensor when q=1 and `return_best` is True (the default). This PR: - Adds a docstring - Replaces `acqf_values[0]` with `acqf_values`. Differential Revision: D61209456
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D61209456 |
esantorella
force-pushed
the
export-D61209456
branch
from
9877287 to
81662f2
Compare
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 13, 2024
Summary: Pull Request resolved: facebook#2652 Context: This was erroring because it was trying to index into a 0d tensor. This issue wasn't caught because the unit test mocked out underlying BoTorch functionality. `optimize_acqf` returns a 0d tensor when q=1 and `return_best` is True (the default). This PR: - Adds a docstring - Replaces `acqf_values[0]` with `acqf_values`. Differential Revision: D61209456
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Aug 14, 2024
Summary: Pull Request resolved: facebook#2652 Context: This was erroring because it was trying to index into a 0d tensor. This issue wasn't caught because the unit test mocked out underlying BoTorch functionality. `optimize_acqf` returns a 0d tensor when q=1 and `return_best` is True (the default). This PR: - Adds a docstring - Replaces `acqf_values[0]` with `acqf_values`. Differential Revision: D61209456
Contributor
|
This pull request has been merged in d8078c5. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: This was erroring because it was trying to index into a 0d tensor. This issue wasn't caught because the unit test mocked out underlying BoTorch functionality.
optimize_acqfreturns a 0d tensor when q=1 andreturn_bestis True (the default).This PR:
acqf_values[0]withacqf_values.Differential Revision: D61209456