SQAAnalysisCard refactor #2644
Closed
SQAAnalysisCard refactor #2644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60258359 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
==========================================
- Coverage 95.31% 95.30% -0.02%
==========================================
Files 492 491 -1
Lines 47644 47542 -102
==========================================
- Hits 45412 45310 -102
Misses 2232 2232 ☔ View full report in Codecov by Sentry. |
Summary: Pull Request resolved: facebook#2644 * Refactor `SQAAnalysis` -> `SQAAnalysisCard` * Delete `SQAAnalysisReport` and related encoders/decoders Reviewed By: danielcohenlive Differential Revision: D60258359
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60258359 |
Cesar-Cardoso
force-pushed
the
export-D60258359
branch
from
8386560 to
9276eaa
Compare
Contributor
|
This pull request has been merged in a3debca. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SQAAnalysis->SQAAnalysisCardSQAAnalysisReportand related encoders/decodersReviewed By: danielcohenlive
Differential Revision: D60258359